New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Add UTF8PROC_NO_INSTALL option #152

Merged

stevengj merged 2 commits into JuliaStrings:master from past-due:cmake_no_install_option

Apr 17, 2019

Contributor

past-due commented Apr 17, 2019

In some cases (such as using the library via add_subdirectory in CMake), it may be desirable to disable installation.

past-due and others added 2 commits

April 17, 2019 10:20


          [CMake] Add UTF8PROC_NO_INSTALL option

537fa48


          change to UTF8PROC_INSTALL

Member

stevengj commented Apr 17, 2019

Thanks, seems reasonable, though it would be better if cmake provided a cleaner way to do this from the parent (as is discussed in various places online, e.g. https://stackoverflow.com/questions/35344132/cpack-exclude-install-commands-from-subdirectory-googletest-directory/35345933, glfw/glfw#30, ...)

I modifed the PR so that it is UTF8PROC_INSTALL=No, however.

stevengj merged commit 4167498 into JuliaStrings:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet