Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Julia 0.5 compatibility #19

Merged
merged 1 commit into from
Jul 28, 2016
Merged

Conversation

stevengj
Copy link
Member

The changes are mostly due to JuliaLang/julia#16024: Julia 0.5 requires you to be a bit more explicit about integer/char conversions. (The same code should work fine in 0.4.)

@chezou
Copy link
Collaborator

chezou commented Jul 28, 2016

Thanks for announcing and sending pull request! I checked it works with Julia 0.5 and 0.4.

@chezou chezou merged commit 6c0ada6 into JuliaStrings:master Jul 28, 2016
@stevengj stevengj deleted the julia-0.5 branch July 28, 2016 14:35
@stevengj
Copy link
Member Author

Great! You should probably tag a new version.

@chezou
Copy link
Collaborator

chezou commented Jul 28, 2016

I did!
JuliaLang/METADATA.jl#5733

2016年7月28日(木) 23:35 Steven G. Johnson notifications@github.com:

Great! You should probably tag a new version.


You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
#19 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA38rWSbTf4tcROVyhQ3ZvaH8er2bBXIks5qaL48gaJpZM4JWd6a
.


Michiaki Ariga
chezou@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants