Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fit method #51

Merged
merged 1 commit into from
Mar 31, 2014
Merged

Add fit method #51

merged 1 commit into from
Mar 31, 2014

Conversation

johnmyleswhite
Copy link
Member

This moves the fit method to StatsBase. Will need to sync up with changes to Distributions that I'll prepare in a moment.

@simonster
Copy link
Member

Thanks for doing this. We should export fit, too.

@simonster
Copy link
Member

Actually, maybe we shouldn't export any of the symbols for functions on StatisticalModel/RegressionModel. They're not useful on their own, and any module that defines these methods will probably want to re-export them anyway.

@johnmyleswhite
Copy link
Member Author

I'm really torn about exporting in general because of the absence of a re-exporting mechanism in Base.

@simonster
Copy link
Member

I agree that we need a better general solution for re-exporting; I have proposed a couple only to realize that reaching an agreement on syntax is difficult. In StatsBase in particular, there's a lot of only vaguely related functionality that should probably live in separate submodules, but for now it's annoying to split it up because of the state of JuliaLang/julia#1986.

In this case, however, I don't think re-exporting is a huge problem since there aren't too many methods and modules that define types that inherit from StatisticalModel will only want to export the symbols for the methods they define anyway.

simonster added a commit to simonster/GLM.jl that referenced this pull request Mar 30, 2014
simonster added a commit to simonster/GLM.jl that referenced this pull request Mar 30, 2014
simonster added a commit to simonster/GLM.jl that referenced this pull request Mar 30, 2014
simonster added a commit to simonster/GLM.jl that referenced this pull request Mar 31, 2014
simonster added a commit that referenced this pull request Mar 31, 2014
@simonster simonster merged commit 34f912b into master Mar 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants