Handle SparseArrays.jl dep as Pkg extension #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 96.98% 96.99% +0.01%
==========================================
Files 1 2 +1
Lines 431 433 +2
==========================================
+ Hits 418 420 +2
Misses 13 13
☔ View full report in Codecov by Sentry. |
|
Well, backporting to v1.9 doesn't make much sense, I guess, since SparseArrays.jl is in the sysimage. But backporting to v1.10 is important. |
|
Uff, I only now realize this is a duplicate of #134. What needs to be done to get this done? Not having SparseArrays.jl as a weak dependency puts a heavy load (time) on downstream packages like Distances.jl. |
|
Not sure. If it is confirmed that weak dependencies don't work for stdlib modules, we will have to finish JuliaLang/julia#46501 first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder if we want to/can/should backport this to v1.9 and v1.10?