-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for changes in nightly #644
Conversation
I added fix related to besseli moving out of base. |
@@ -1,4 +1,4 @@ | |||
""" | |||
doc""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be necessary. Were you seeing failures without it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Otherwise one can escape the backslashes, I followed "doc_str should only be used when the docstring contains $ or \ characters that should not be parsed by Julia such as LaTeX syntax or Julia source code examples containing interpolation" from https://docs.julialang.org/en/latest/manual/documentation/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, thanks. #640 escapes all of the backslashes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc_str
doesn't play nice with documenter as a result #640 intentionally removes most of the doc_str
s in the code and escapes everything accordingly.
@@ -2,6 +2,7 @@ | |||
|
|||
using Distributions | |||
using Base.Test | |||
using SpecialFunctions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure how the tests work at all on 0.6+ without this.
Triggered by JuliaLang/julia#22800