Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for changes in nightly #644

Merged
merged 2 commits into from
Jul 18, 2017
Merged

Fixes for changes in nightly #644

merged 2 commits into from
Jul 18, 2017

Conversation

mschauer
Copy link
Member

Triggered by JuliaLang/julia#22800

@mschauer
Copy link
Member Author

I added fix related to besseli moving out of base.

@mschauer mschauer changed the title Missing doc_str Fixes for changes in nightly Jul 18, 2017
@@ -1,4 +1,4 @@
"""
doc"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary. Were you seeing failures without it?

Copy link
Member Author

@mschauer mschauer Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Otherwise one can escape the backslashes, I followed "doc_str should only be used when the docstring contains $ or \ characters that should not be parsed by Julia such as LaTeX syntax or Julia source code examples containing interpolation" from https://docs.julialang.org/en/latest/manual/documentation/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, thanks. #640 escapes all of the backslashes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc_str doesn't play nice with documenter as a result #640 intentionally removes most of the doc_strs in the code and escapes everything accordingly.

@@ -2,6 +2,7 @@

using Distributions
using Base.Test
using SpecialFunctions
Copy link
Member

@ararslan ararslan Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure how the tests work at all on 0.6+ without this.

@ararslan ararslan merged commit 2c5eb10 into JuliaStats:master Jul 18, 2017
@rofinn rofinn mentioned this pull request Jul 18, 2017
@mschauer mschauer deleted the patch-2 branch July 18, 2017 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants