Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve with AdjointFactorization of Cholmod and Adjoint rhs #595

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

dkarrasch
Copy link
Member

Fixes #594.

@dkarrasch dkarrasch requested a review from rayegun January 12, 2025 17:28
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (5f52721) to head (c776ef6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   84.06%   84.06%           
=======================================
  Files          12       12           
  Lines        9191     9192    +1     
=======================================
+ Hits         7726     7727    +1     
  Misses       1465     1465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jonas-schulze jonas-schulze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the swift solution! I wonder why the new method of (\) is not covered by the tests. 👀

Could this be backported to Julia 1.10, please?

test/cholmod.jl Outdated Show resolved Hide resolved
@dkarrasch
Copy link
Member Author

Could this be backported to Julia 1.10, please?

I'm not sure about that. @ViralBShah @KristofferC This was failing due to a "missing method". I guess this counts more like a "new feature" rather than "bugfix".

@jonas-schulze If we decide against backporting, you could commit type piracy in your package and define this one method in a version-dependent branch...? I know it's not optimal, but I personally have used all my credits (if I ever had some) for arguing in favor of a semver-breaking action. 😅

@dkarrasch dkarrasch merged commit 212981b into main Jan 16, 2025
10 checks passed
@dkarrasch dkarrasch deleted the dk/adjcholadjrhs branch January 16, 2025 09:33
@ViralBShah
Copy link
Member

I think it is ok to backport it, but @KristofferC should be the person to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot solve with AdjointFactorization of Cholesky factorizations and Adjoint right-hand side
3 participants