Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DataFrames to 1 #91

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Jun 10, 2021

The constructor DataFrame(types, names, 0) is has been removed from DataFrames.jl. So, I used the one suggested in this discussion after DataFrames' modification.

I dropped DataFrames 0.22 as it has no compatible environment here, but surprisingly 0.21 does.

I expect the unit test to pass on the nightly at this point.

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #91 (03f240d) into master (81a90b6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   76.30%   76.30%           
=======================================
  Files          13       13           
  Lines         287      287           
=======================================
  Hits          219      219           
  Misses         68       68           
Impacted Files Coverage Δ
src/pkgbmark.jl 76.31% <100.00%> (ø)
src/run_solver.jl 86.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a90b6...03f240d. Read the comment docs.

@tmigot tmigot marked this pull request as draft June 10, 2021 17:49
@tmigot
Copy link
Member Author

tmigot commented Jun 10, 2021

So, it doesn't pass the nightly tests with a new error that has been added yesterday as an issue in JLD2.jl.

@tmigot tmigot marked this pull request as ready for review June 10, 2021 18:09
@dpo
Copy link
Member

dpo commented Jun 10, 2021

Let's move on.

@dpo dpo merged commit b2aef15 into JuliaSmoothOptimizers:master Jun 10, 2021
@tmigot tmigot deleted the bump-dataframes-1 branch June 10, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants