Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support quadratic constraints #181

Merged
merged 21 commits into from
Jun 21, 2024

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Jun 20, 2024

close #50
close #149
close #150
@tmigot You should be happy now 😃

@amontoison amontoison requested a review from tmigot June 20, 2024 04:09
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Package name latest stable
NLSProblems.jl
OptimizationProblems.jl

@amontoison
Copy link
Member Author

@tmigot We should probably add HS61, HS100 and HS219 in NLPModelsTest.jl for more robust tests.

@amontoison
Copy link
Member Author

If we replace @NLconstraint with @constraint for the quadratic constraints in hs6, hs10, hs11, and hs14, almost all tests pass.
The failing tests are related to this issue: JuliaSmoothOptimizers/NLPModelsTest.jl#109.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 74.27653% with 80 lines in your changes missing coverage. Please review.

Project coverage is 86.94%. Comparing base (5bb0b82) to head (02317b4).

Current head 02317b4 differs from pull request most recent head f39f1e4

Please upload reports for the commit f39f1e4 to get more accurate results.

Files Patch % Lines
src/utils.jl 57.28% 44 Missing ⚠️
src/moi_nls_model.jl 65.04% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   93.00%   86.94%   -6.07%     
==========================================
  Files           4        5       +1     
  Lines         629      919     +290     
==========================================
+ Hits          585      799     +214     
- Misses         44      120      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amontoison ! Thanks for the PR that's great.
I just had minor comments to add some tests.
How did you verify the result?

src/utils.jl Show resolved Hide resolved
src/utils.jl Show resolved Hide resolved
test/nlp_problems/hs100.jl Outdated Show resolved Hide resolved
src/utils.jl Show resolved Hide resolved
@tmigot tmigot mentioned this pull request Jun 21, 2024
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amontoison ! It looks good to me.
I think we just need a problem in NLPModelsTest that has both quadratic and nonlinear constraints.
Let's go for 0.13.0 when you are ready.

@amontoison amontoison merged commit c12dc0c into JuliaSmoothOptimizers:main Jun 21, 2024
14 of 18 checks passed
@amontoison amontoison deleted the quadcon branch June 21, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants