Add getter for NLPModelMeta and NLSMeta
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 99.65% 99.66%
=======================================
Files 12 13 +1
Lines 585 589 +4
=======================================
+ Hits 583 587 +4
Misses 2 2
Continue to review full report at Codecov.
|
|
|
|
Hope it was ok to merge! |
Yes, it was ok to merge. The |
baggepinnen
added a commit
to baggepinnen/MadNLP.jl
that referenced
this pull request
Aug 31, 2022
It appears as if 1. The names have changed to `x0, y0` 2. The getters have been introduced JuliaSmoothOptimizers/NLPModels.jl#371
sshin23
pushed a commit
to MadNLP/MadNLP.jl
that referenced
this pull request
Sep 1, 2022
It appears as if 1. The names have changed to `x0, y0` 2. The getters have been introduced JuliaSmoothOptimizers/NLPModels.jl#371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way calling
get_minimize(meta)would no longer allocate the 2nd call, whilemeta.minimizewould always.For each attribute
fooin the meta, there is aget_foofunction.Note that there is a priority for NLS over NLP for copies in NLPMeta and NLSMeta, e.g.
get_x0(nls)will look fornls.nls_meta.x0.