Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30
The main change in this PR is to replace
Tuple
s byVector
s, as the size of an array will not be type-inferred in general. Also replace1:m
by the corresponding array axis, which may help preserve static array sizes (aside from being safer when indexing into an array).After this,
Ideally, this should be even faster, but at least it's in the same ballpark now.
A further improvement may be to use aggressive constant propagation, which may help improve type-inference for static arrays, where each axis may have a different size. This isn't included in this PR.