Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md for new triage-level powers #99707

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

ericphanson
Copy link
Member

@ericphanson ericphanson commented Jan 28, 2024

To be merged once JuliaRegistries/RegistryCI.jl#536 is operational on General

Created by: @ericphanson
extra line

@DilumAluthge
Copy link
Member

Might as well use this PR to do a quick test.

[merge approved]

@ericphanson
Copy link
Member Author

Nice, looks like that run successfully and correctly decided not to apply the label. Now I've edited myself in to the OP, let's try the other path:

[merge approved]

@ericphanson
Copy link
Member Author

uh oh, looks like maybe the regex didn't match? https://github.com/JuliaRegistries/General/actions/runs/7703098268/job/20992809499

@ericphanson
Copy link
Member Author

I think I was missing a newline after the "Created by" in the OP.

[merge approved]

@ericphanson
Copy link
Member Author

Had an extra space before the newline....

[merge approved]

@DilumAluthge
Copy link
Member

@ericphanson Can we add some unit tests for this regex to the RegistryCI.jl test suite?

@DilumAluthge
Copy link
Member

Can you use the GitHub API locally to pull the contents of the PR description? So we can see exactly what the characters are.

@ericphanson
Copy link
Member Author

I think it's something to do with the newline at the end. I think we should just go back to the regex I had before, I had tested that one thoroughly on another repo and it was working well.

@DilumAluthge
Copy link
Member

GitHub is giving \r\n instead of \n for the newline.

@ericphanson
Copy link
Member Author

#99796

@ericphanson
Copy link
Member Author

[merge approved]

@ericphanson
Copy link
Member Author

ericphanson commented Jan 29, 2024

Progress!

GraphQL: Your token has not been granted the required scopes to execute this query. The 'login' field requires one of the following scopes: ['read:org'], but your token has only been granted the: ['delete_repo', 'read:user', 'repo', 'workflow'] scopes. Please modify your token's scopes at: https://github.com/settings/tokens., Your token has not been granted the required scopes to execute this query. The 'name' field requires one of the following scopes: ['read:org', 'read:discussion'], but your token has only been granted the: ['delete_repo', 'read:user', 'repo', 'workflow'] scopes. Please modify your token's scopes at: https://github.com/settings/tokens., Your token has not been granted the required scopes to execute this query. The 'slug' field requires one of the following scopes: ['read:org', 'read:discussion'], but your token has only been granted the: ['delete_repo', 'read:user', 'repo', 'workflow'] scopes. Please modify your token's scopes at: https://github.com/settings/tokens.

https://github.com/JuliaRegistries/General/actions/runs/7703569853/job/20994230574

@ericphanson
Copy link
Member Author

can you update the token @DilumAluthge ? It sounds like it additionally just needs read:org and that would fix the 3 errors it's reporting

@ericphanson
Copy link
Member Author

ok let's try again

[merge approved]

@ericphanson
Copy link
Member Author

one more:
[merge approved]

@DilumAluthge
Copy link
Member

Nice!

And just to check it doesn't work for me:

[merge approved]

@ericphanson ericphanson marked this pull request as ready for review January 30, 2024 14:24
@ericphanson ericphanson merged commit 192d63d into master Jan 30, 2024
16 checks passed
@ericphanson ericphanson deleted the eph/triage-override branch January 30, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants