-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md for new triage-level powers #99707
Conversation
To be merged once JuliaRegistries/RegistryCI.jl#536 is operational on General
Might as well use this PR to do a quick test. [merge approved] |
Nice, looks like that run successfully and correctly decided not to apply the label. Now I've edited myself in to the OP, let's try the other path: [merge approved] |
uh oh, looks like maybe the regex didn't match? https://github.com/JuliaRegistries/General/actions/runs/7703098268/job/20992809499 |
I think I was missing a newline after the "Created by" in the OP. [merge approved] |
Had an extra space before the newline.... [merge approved] |
@ericphanson Can we add some unit tests for this regex to the RegistryCI.jl test suite? |
Can you use the GitHub API locally to pull the contents of the PR description? So we can see exactly what the characters are. |
I think it's something to do with the newline at the end. I think we should just go back to the regex I had before, I had tested that one thoroughly on another repo and it was working well. |
GitHub is giving |
[merge approved] |
Progress!
https://github.com/JuliaRegistries/General/actions/runs/7703569853/job/20994230574 |
can you update the token @DilumAluthge ? It sounds like it additionally just needs |
ok let's try again [merge approved] |
one more: |
Nice! And just to check it doesn't work for me: [merge approved] |
To be merged once JuliaRegistries/RegistryCI.jl#536 is operational on General
Created by: @ericphanson
extra line