Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: CLIMAParameters v0.6.5 #65522

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 6eacf6c3-8458-43b9-ae03-caf5306d3d53
Repo: https://github.com/CliMA/CLIMAParameters.jl.git
Tree: ae2d47cc5f23c894474552a91c62ce3921082aef

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
JuliaRegistrator referenced this pull request in CliMA/ClimaParams.jl Aug 3, 2022
100: new microphysics parameter - steepness of smooth transition r=trontrytel a=sajjadazimi

# PULL REQUEST

## Purpose and Content
A parallel PR in CloudMicrophysics is created where auto conversion rates are modified by using logistic functions to make transition between different parameter regimes at thresholds smooth. Here a parameter is added that characterize the steepness of the transition.

## Benefits and Risks
This will prevent abrupt changes of process rates in different parameter regimes. No risk: functions by default return the old process rates unless a boolean is changed, so the code modification will not cause contradictory results.

## PR Checklist
- This PR has a corresponding issue OR is linked to an SDI.
- I have followed CliMA's codebase [contribution](https://clima.github.io/ClimateMachine.jl/latest/Contributing/) and [style](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) guidelines OR N/A.
- I have followed CliMA's [documentation policy](https://github.com/CliMA/policies/wiki/Documentation-Policy).
- I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
- I linted my code on my local machine prior to submission OR N/A.
- Unit tests are included OR N/A.
- Code used in an integration test OR N/A.
- All tests ran successfully on my local machine OR N/A.
- All classes, modules, and function contain docstrings OR N/A.
- Documentation has been added/updated OR N/A.


Co-authored-by: Sajjad Azimi <azimi@caltech.edu>
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch August 3, 2022 01:17 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@JuliaTagBot JuliaTagBot merged commit c4fbeec into master Aug 3, 2022
@JuliaTagBot JuliaTagBot deleted the registrator/climaparameters/6eacf6c3/v0.6.5 branch August 3, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants