New version: Oceananigans v0.55.1 #34911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JuliaRegistrator
commented
Apr 21, 2021
JuliaRegistrator
commented
- Registering package: Oceananigans
- Repository: https://github.com/CliMA/Oceananigans.jl
- Created by: @glwagner
- Version: v0.55.1
- Commit: dd1f949822a3427320fefec0d57401a6634269b3
- Reviewed by: @glwagner
- Reference: CliMA/Oceananigans.jl@dd1f949#commitcomment-49819167
UUID: 9e8cae18-63c1-5223-a75c-80ca9d6e9a09 Repo: https://github.com/CliMA/Oceananigans.jl.git Tree: 517acba5d051216bbd7b63ad40f4c9293193eb2a Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
JuliaRegistrator
referenced
this pull request
in CliMA/Oceananigans.jl
Apr 21, 2021
…rations (#1596) * Changes fourth type parameter of AbstractField to architecture * Adds architecture property to all fields * Updates set! for new AbstractField type parameters * Update constructor for AveragedField * Adds architecture property to BuoyancyField * Fixes cpudata * set! for GPU fields is identitcal for arrays and functions * Technical debt *sigh* * Subtype abstract array * Refactors AbstractField infrastructure to subtype AbstractArray * Implements copyto! for in-place broadcasting to dest::AbstractField * Remove spurious setindex! for Field * Adds back manual reduction functions (hopefully we can get rid of these eventually) * Only reduce fields backed by concrete data * Adds 2d, 1d, and 0d Cartesian indexing for ReducedFields, and more flexible broadcast_2d! kernel * Expand definitions of Base.similar for AbstractField and AbstractReducedField * Dont copy boundary conditions in similar * Removes calls to parent() in conjugate gradient iteration * Dont test that similar fields have the same boundary conditions * Cleans up AveragedField test for different Float types * Fields take eltype from grid * Fixes typo in KernelComputedField constructor * Update fill_halo_regions dispatch now that Field<:AbstractArray * Move fill_halo_regions for fields to AbstractField * Adds some rudimentary broadcasting test for Fields * Dont convert arrays to tuples * Cleans up KernelComputedField * Adds show method for kernelComputedField * Better docstring for Field * Fixes bug in test for broadcasting with ReducedField * Simplifies KernelComputedField tests * Different kernels for different 2d configurations * Converts broadcasted to abstract operations where appropriate * Needed eval after all * AbstractOperations lists are symbols? * Disambiguate distributed Field constructor * Get AbstractGrid into Distributed * Provide rules for broadcasting Fields with Arrays * Import missing functions and types from Base.Broadcast * Adds a new function at(loc, op) for changing the location of AbstractOperations * Its not a derivative _operation_..." * Attempts to insert logic to insert locations into broadcasted field expressions * Refactors AbstractOperations to be more broadly useful in broadcasting * Improvements to braodcasting field operations * Fixes bug in broadcasting test for ReducedField * Dont use BroadcastStyle just yet until we can get it working * Defines linear indexing and fill! for fields * Redefine checkbounds for AbstractField * Starts implementing new checkbounds pending appropriate parentaxes function for fields * BuoyancyField is backed by data * Banishes parent() from preconditioned_conjugate_gradient_solver * Import AbstractDataField into Buoyancy * Specifies fill_halo_regions to OffsetArray for distributed models * More general location inference for binary operations * Add identity to list of unary operators * Adds additional type parameter to zero field * Revert "Adds additional type parameter to zero field" This reverts commit 1a77150. * Dont restrict i, j, k to integer * Field getindex over data getindex * Introduces "stubborn" binary operations * Converts Broadcasted to AbstractOperations when destination is a field * Cleans up doc strings and adapt_structure for AbstractOperations * Fix some scoping issues with interpolation wrapper for at macro * Move interpolate_operation definition to at.jl * No need to throw errors for operations at Nothing location * Computations with AveragedField might work? * Adds incremental build up of AveragedField operations testing * Dont interpolate unecessarily * Bugfix in abstract operations tests * Cleans up merge issues in AbstractOperations * Use custom binary op function for getindex * No more test skip in abstrsct operations tests! * Holy typo * Fix merge-added typo; * Move broadcasting tests to simulation group * Add new test group for abstract operations and broadcasting * Updates testset description to include broadcasting * Fixes superfluous include(at.jl) * Infer whether broadcast requires interpolation or not * More broadcasting tests including for interpolation * Creates new binary operator functions to help type inference * Broadcasting shenanigans * Fixes bugs in broadcasting tests * Finds BroadcastStyle name * Defines fallback for interpolate_operation * Polish off interpolation for broadcasting * Updates broadcasting tests * Field takes eltype from grid * Test a few unaries but not all * interpolate_identity is officially a unary * Test explicit set of unaries * Update unary_operations.jl * Update kelvin_helmholtz_instability.jl * Removes wrong comments * Bump version * No need for needs_interpolation
|
Your If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.