Allow LibGit2_jll 1.0 on Julia 1.6 #18959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, because Julia v1.6 still doesn't support LibGit v1 |
|
Ah, OK, I thought I needed to allow 1.6 before merging the PR, but indeed I just tested it and it's not the case. So let's keep this PR as a draft until JuliaLang/julia#35233 has been merged. |
|
bump |
|
Since 1.0.1 we allow any Julia version above 1 AFAICT: 8d478c3 |
|
So this is not relevant? Or should 1.0.0 also be allowed on earlier Julia? |
|
Yeah, I guess. See #18959. |
|
Is LibGit2 v1.0 API/ABI compatible with the old ones? |
|
No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by JuliaLang/julia#35233.
@giordano Is there a particular reason why you required Julia 1.7 when you registered the package (as mentioned here)?