Use stddev from benchmark to do a statistical test #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently get some random test failures, because the benchmarks are hardcoded to be "within 1.2 times the time from Distributed". I found that:
@belapsed
is the minimum time, not mean time. That's still an interesting measure (which gets more accurate with more samples) but I believe it has a higher spread? In any case, my intention is to test mean time.seconds=1
makes our tests fast but not worth the high random failure rateRight now the PR changes our goal to be "97% sure that we are not slower".
This should probably be: "97% sure that we are not more than 20% slower". EDIT no its fine