UnicodePlots.jl is failing on the daily PkgEval runs

[DilumAluthge]

UnicodePlots.jl is failing on the daily PkgEval runs. See for example: https://juliaci.github.io/NanosoldierReports/pkgeval_badges/U/UnicodePlots.html

[Evizero]

looks like the cause is here

ERROR: LoadError: ArgumentError: Package Random not found in current path:
- Run `import Pkg; Pkg.add("Random")` to install the Random package.

[waldyrious]

@johnnychen94 shouldn't this issue be reopened, considering that the PkgEval runs are still failing?

[johnnychen94]

Interesting... I thought #136 fixes this already.

[t-bltg]

Seems like we lost some ansi color codes with 1.8.0.

[t-bltg]

Test pass on 1.7.0 rc1.
Test pass on nightly 1.8.0 (Version 1.8.0-DEV.593 (2021-09-24) - Commit 53aa65ad3c (1 day old master)).

@DilumAluthge, this looks like a CI specific issue, not sure how I can fix this without more info.

[DilumAluthge]

Here's the log: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2021-09/25/UnicodePlots.1.8.0-DEV-53aa65ad3c9.log

I think it has to do with color. Color is disabled in PkgEval.

cc: @maleadt

[johnnychen94]

Do we have a way to detect if color is enabled inside Julia? If so we can optionally disable some color tests.

[maleadt]

julia> Base.get_have_color()
true

Not sure how officially sanctioned that is though.

[DilumAluthge]

julia> Base.get_have_color()
true

Not sure how officially sanctioned that is though.

On older Julia versions, I don't think that will work. This is what @KristofferC does in Crayons.jl to support both older and newer Julia versions:

function _have_color()
    if isdefined(Base, :get_have_color)
        return Base.get_have_color()
    else
        Base.have_color
    end
end

Source: https://github.com/KristofferC/Crayons.jl/blob/2619561156a02fdf739c8146e09a96ceb176f43c/src/crayon.jl#L102

[KristofferC]

This is what @KristofferC does in Crayons.jl to support both older and newer Julia versions:

I am not sure this is a good way at all though.

I think the correct way is to always print to an IO with color enabled:

base ❯ julia -q --color=no

julia> printstyled(IOContext(stdout, :color => true), "foo"; color=:green)
foo # printed in green anyway

Edit: But that is what the tests are already doing now I see.

[DilumAluthge]

This is what @KristofferC does in Crayons.jl to support both older and newer Julia versions:

I am not sure this is a good way at all though.

I think the correct way is to always print to an IO with color enabled:

base ❯ julia -q --color=no

julia> printstyled(IOContext(stdout, :color => true), "foo"; color=:green)
foo # printed in green anyway

If I recall, we tried that approach, but it still ended up failing on PkgEval.

[KristofferC]

It is maybe Crayons.jl fault then. KristofferC/Crayons.jl#47 maybe.

[DilumAluthge]

Ahhhh yeah it might be KristofferC/Crayons.jl#47.

[t-bltg]

Thanks for the hints. We don't use show on Crayons objects, we only use Crayons.val(...) to get the ansicolor index:

UnicodePlots.jl/src/common.jl

Line 260 in f7c123e

function crayon_256_color(color::UserColorType)::ColorType

I'm gonna test with julia --color=no and see if I can reproduce this locally.

EDIT: yes it does, fixing this asap, I forgot about this bit in HeatmapCanvas:

UnicodePlots.jl/src/canvas/heatmapcanvas.jl

Line 48 in f7c123e

print(io, Crayon(foreground=fgcol, background=bgcol), HALF_BLOCK)

[t-bltg]

Confirmed fix, UnicodePlots is absent from today's nanosoldier report.

[waldyrious]

Confirmed fix, UnicodePlots is absent from today's nanosoldier report.

Nice! Btw, perhaps the PkgEval badge (as shown in the opening commit) could be added to the README, next to the other CI ones?