Fix representation of zero-valued bins on step-histograms with log-y axis #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bins with weight NaN and zero (which the Plots engine seems to turn into into NaN automatically for log-yscale) should not be draws in log-yscale.
|
Regarding CI failing on Travis: I get a difference of about 0.001 for the three failed image comparisons when I run the tests locally (on Linux). So I think they're actually fine. How do I make Plots store the results of the test run as image files, for a visual comparison? I know there's a way, but I forgot how. |
This should be easier once #2064 is merged: see #2062 (review) |
|
The reasons for the tests failing is a change in Showoff v0.3.0 (introduced by myself 😓). There's already a fix, we just have to wait until v0.3.1 gets registered (JuliaRegistries/General#1671). |
|
Thanks, @daschw ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero-values bins are at minus infinity on y-logscale, so they shouldn't be drawn.
Before:
After: