Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct unit of Stefan-Boltzmann-Constant #11

Merged
merged 3 commits into from
Apr 28, 2019
Merged

correct unit of Stefan-Boltzmann-Constant #11

merged 3 commits into from
Apr 28, 2019

Conversation

simeonschaub
Copy link
Contributor

No description provided.

@giordano
Copy link
Member

🙈

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           2        2           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e965c2...56e9599. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           2        2           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e965c2...60e4385. Read the comment docs.

@giordano
Copy link
Member

Thank you so much for spotting this error! I added a test, just to make sure I'll avoid the same error in the future

@giordano giordano merged commit b99e9f8 into JuliaPhysics:master Apr 28, 2019
@simeonschaub
Copy link
Contributor Author

Glad I could help! Thanks for this awesome package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants