Add CPK coloring #35
Merged
Add CPK coloring #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneiderfelipe
force-pushed
the
cpk-hex-colors
branch
from
c46c240
to
5793ba3
Compare
|
@rahulkp220 Mind if I tag a new release? |
|
@crstnbr Yes sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CPK colors (color convention for distinguishing chemical elements in physical and digital molecular models) for all elements that have this property defined in Bowserinator/Periodic-Table-JSON (in total, 109 elements).
The property was defined as a string (that defaults to
""), but this can be changed if someone has a better idea (Colors.jl?)