Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp using new PETSc_jll binaries #99

Merged
merged 23 commits into from
Sep 1, 2020
Merged

Revamp using new PETSc_jll binaries #99

merged 23 commits into from
Sep 1, 2020

Conversation

simonbyrne
Copy link
Member

No description provided.

src/const.jl Outdated Show resolved Hide resolved
@simonbyrne simonbyrne force-pushed the sb/revamp branch 3 times, most recently from 68a826d to eaffc9f Compare August 26, 2020 05:07
@simonbyrne
Copy link
Member Author

@stevengj would you have any objection to me merging this? I realise it's not complete (in terms of functionality vs the old code), but it would make it easier for us to do more incremental development.

@simonbyrne
Copy link
Member Author

@JaredCrean2 as well

@thomasgibson
Copy link
Member

@simonbyrne This has been a great start! I tried to see how far we can push the specification of solver options. Here is an example using CG plus PETSc's native AMG preconditioner: 2026516

I think there is some issue with nesting options prefixes - or perhaps I am missing something?

@stevengj
Copy link
Contributor

That's fine with me.

Are you planning to manually translate the Petsc headers rather than using Clang.jl?

@simonbyrne
Copy link
Member Author

I think so: the bigger challenge is keeping track of object lifetimes and figuring out correct return objects, which generated wrappers can't help with.

@stevengj
Copy link
Contributor

stevengj commented Aug 30, 2020

Yes, that seems reasonable to me. My initial plan was to do manual header translation, but the Petsc guys got upset with that suggestion and felt that we couldn't possibly keep up with their advanced API changes (see JuliaLang/julia#2645). To the extent that we are focused on providing high-level APIs, however, I don't think that is a problem.

@simonbyrne simonbyrne marked this pull request as ready for review September 1, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants