[open62541] v1.3.10, split off v1.4 #8522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Apr 24, 2024
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After building open62541 v1.4 with #7889 rebuilding the wrapper package using Clang.jl proves difficult. Segfaults are encountered when running simple server test cases and figuring out the exact source has been difficult for me so far.
With this PR, I would like to build v.1.3.10 without OpenSSL support and without header amalgamation, while having v.1.4 separately around (unchanged). The hope is that I can first update the generator scripts used in Clang.jl to reflect the lack of amalgamated header file on the patch release 1.3.10 without introducing multiple larger changes (addition of OpenSSL + upgrade to v1.4 (which unfortunately seems to contain some breaking changes - at least as seen from the perspective of my wrapper))
Hopefully I did the splitting of the versions correctly...