Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSSL: install libraries in lib not lib64 #8393

Merged
merged 2 commits into from
Mar 31, 2024
Merged

OpenSSL: install libraries in lib not lib64 #8393

merged 2 commits into from
Mar 31, 2024

Conversation

fxcoudert
Copy link
Contributor

To be consistent with other libraries, libcrypto and libssl should be installed in lib/ (not lib64/) on x86_64-linux. I found out about this because of JuliaLang/julia#53891

@fxcoudert
Copy link
Contributor Author

This would also make it possible to remove these:

./N/nats_c/build_tarballs.jl:    export OPENSSL_ROOT_DIR=${prefix}/lib64/
./M/mosquitto_client/build_tarballs.jl:    export OPENSSL_ROOT_DIR=${prefix}/lib64/
./L/LibSSH2/build_tarballs.jl:    export OPENSSL_ROOT_DIR=${prefix}/lib64
./L/libssh/build_tarballs.jl:    export OPENSSL_ROOT_DIR=${prefix}/lib64
./L/LibGit2/build_tarballs.jl:    export OPENSSL_ROOT_DIR=${prefix}/lib64
./L/libdatachannel/build_tarballs.jl:    export OPENSSL_ROOT_DIR="${prefix}/lib64"

@fxcoudert fxcoudert mentioned this pull request Mar 31, 2024
Open
@giordano
Copy link
Member

While we're at it, is there a way to disable building the static library? A quick look at the Configure script didn't catch anything relevant there.

@giordano
Copy link
Member

Ok, no, it doesn't seem to be possible automatically: openssl/openssl#8823.

@giordano giordano merged commit ab9712b into JuliaPackaging:master Mar 31, 2024
19 checks passed
@fxcoudert fxcoudert deleted the openssl-libdir branch April 1, 2024 08:01
staticfloat added a commit that referenced this pull request Jun 15, 2024
@staticfloat
[LibSSH2] Re-build to lock compatibility with OpenSSL v3.0.14+
342cf52 
In #8393 we changed the layout of OpenSSL to put libraries in `${prefix}/lib` rather than `${prefix}/lib64`.  While this doesn't effect Julia much, if one uses a tool such a `JLLPrefixes` to plop a bunch of JLL's artifacts in a single prefix and then try to use the binaries directly, the RPATHs no longer work.  This rebuild will create a new version of LibSSH2 that will work with the new OpenSSL binaries.
@staticfloat staticfloat mentioned this pull request Jun 15, 2024
Merged
staticfloat added a commit that referenced this pull request Jun 15, 2024
@staticfloat
[LibSSH2] Re-build to lock compatibility with OpenSSL v3.0.14+ (#8898)
46acfe3 
In #8393 we changed the layout of OpenSSL to put libraries in `${prefix}/lib` rather than `${prefix}/lib64`.  While this doesn't effect Julia much, if one uses a tool such a `JLLPrefixes` to plop a bunch of JLL's artifacts in a single prefix and then try to use the binaries directly, the RPATHs no longer work.  This rebuild will create a new version of LibSSH2 that will work with the new OpenSSL binaries.
amontoison pushed a commit that referenced this pull request Jun 22, 2024
@staticfloat @amontoison
[LibSSH2] Re-build to lock compatibility with OpenSSL v3.0.14+ (#8898)
a10b3fe 
In #8393 we changed the layout of OpenSSL to put libraries in `${prefix}/lib` rather than `${prefix}/lib64`.  While this doesn't effect Julia much, if one uses a tool such a `JLLPrefixes` to plop a bunch of JLL's artifacts in a single prefix and then try to use the binaries directly, the RPATHs no longer work.  This rebuild will create a new version of LibSSH2 that will work with the new OpenSSL binaries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxcoudert @giordano