Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCC] Add libgomp patch for NULL environ (v13.2.0) #8205

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

topolarity
Copy link
Contributor

@topolarity topolarity commented Feb 27, 2024

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111413, this is a fix for JuliaLang/julia#53363

It's actually a workaround for a deeper issue (python/cpython#116015) that Python is built without -fPIC by many maintainers, causing libraries like libgomp when loaded with RTLD_DEEPBIND not to see the correct environ that should have been initialized by glibc. However, the bugfix is also required for clearenv() so it's worth carrying anyway.

@giordano giordano added the BinaryBuilder ⚙️ Issues and pull requested related to internals of BinaryBuilder label Feb 28, 2024
@topolarity
Copy link
Contributor Author

Anything you need from me here @giordano?

@gbaraldi
Copy link
Contributor

gbaraldi commented Mar 4, 2024

Companion PR in JuliaPackaging/BinaryBuilderBase.jl#369

@giordano
Copy link
Member

giordano commented Mar 4, 2024

Anything you need from me here @giordano?

No, thanks!

@giordano giordano merged commit 8247c75 into JuliaPackaging:master Mar 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BinaryBuilder ⚙️ Issues and pull requested related to internals of BinaryBuilder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants