-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LibPQ] Bump to 16 and align OpenSSL with HDF5 #7053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinGW build error:
|
@giordano I'm out of ideas about how to get Windows to build |
jeremiahpslewis
changed the title
[LibPQ] Bump to 15.3 and align OpenSSL with HDF5
[LibPQ] Bump to 16 and align OpenSSL with HDF5
Sep 15, 2023
@giordano my guess is that using two different build systems for one binary is a significant code smell, but I can't get either build system to build across all targets with OpenSSL 3. |
While unfortunate, this looks reasonable to me. Reading the script, it was obvious what is happening, which is good enough, imo. |
Merged
giordano
reviewed
Sep 18, 2023
giordano
reviewed
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: at the moment, super ugly compromise where
./configure
old build system is used for apple, newmeson
build system is used for everything else. As themeson
build system was just launched, I expect future releases are likely to be easier to build on apple and we can go back to using one consistent build system (./configure
builds don't work on windows).