Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LibPQ] Bump to 16 and align OpenSSL with HDF5 #7053

Merged
merged 27 commits into from
Sep 19, 2023

Conversation

jeremiahpslewis
Copy link
Contributor

@jeremiahpslewis jeremiahpslewis commented Jul 14, 2023

NOTE: at the moment, super ugly compromise where ./configure old build system is used for apple, new meson build system is used for everything else. As the meson build system was just launched, I expect future releases are likely to be easier to build on apple and we can go back to using one consistent build system (./configure builds don't work on windows).

@jeremiahpslewis
Copy link
Contributor Author

MinGW build error:



06:35:00] checking for library containing CRYPTO_new_ex_data... no
--
  | [06:35:00] configure: error: library 'eay32' or 'crypto' is required for OpenSSL
  | [06:35:00]  ---> ./configure --prefix=${prefix} --build=${MACHTYPE} --host=${target} --with-includes=${includedir} --with-libraries=${libdir} --without-readline --without-zlib --with-ssl=openssl "${FLAGS[@]}"
  | [06:35:00]  ---> ./configure --prefix=${prefix} --build=${MACHTYPE} --host=${target} --with-includes=${includedir} --with-libraries=${libdir} --without-readline --without-zlib --with-ssl=openssl "${FLAGS[@]}"
  | [06:35:00] Previous command exited with 1
  | [06:35:00] Child Process exited, exit code 1

@jeremiahpslewis
Copy link
Contributor Author

@giordano I'm out of ideas about how to get Windows to build

@jeremiahpslewis jeremiahpslewis changed the title [LibPQ] Bump to 15.3 and align OpenSSL with HDF5 [LibPQ] Bump to 16 and align OpenSSL with HDF5 Sep 15, 2023
@jeremiahpslewis
Copy link
Contributor Author

@giordano my guess is that using two different build systems for one binary is a significant code smell, but I can't get either build system to build across all targets with OpenSSL 3.

@aviks
Copy link
Contributor

aviks commented Sep 18, 2023

While unfortunate, this looks reasonable to me. Reading the script, it was obvious what is happening, which is good enough, imo.

@visr visr mentioned this pull request Sep 18, 2023
L/LibPQ/build_tarballs.jl Outdated Show resolved Hide resolved
@giordano giordano merged commit bccb4f0 into JuliaPackaging:master Sep 19, 2023
@visr visr mentioned this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants