Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Gloo to v0.0.20200910 #4571

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Mar 7, 2022

No description provided.

@stemann stemann changed the title Feature/gloo 20200910 Updated Gloo to v0.0.20200910 Mar 7, 2022
@stemann stemann mentioned this pull request Mar 7, 2022
@stemann
Copy link
Contributor Author

stemann commented Mar 17, 2022

@giordano
Copy link
Member

All header files in mingw are lowercase:

sandbox:${WORKSPACE} # qfind /opt/${target}/${target} -iname BaseTsd.h
/opt/x86_64-w64-mingw32/x86_64-w64-mingw32/sys-root/include/basetsd.h

@stemann stemann force-pushed the feature/Gloo-20200910 branch 3 times, most recently from f727892 to 79ce38e Compare April 2, 2022 06:50
@stemann stemann marked this pull request as ready for review August 24, 2022 10:58
@@ -0,0 +1,13 @@
diff --git a/gloo/types.h b/gloo/types.h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to upstream all the patches

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

@giordano giordano merged commit 3e0e28c into JuliaPackaging:master Aug 24, 2022
@stemann stemann deleted the feature/Gloo-20200910 branch August 24, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants