Wizard recipe: KaHyPar-v1.2.1 #3111
Conversation
|
I think unfortunately kahypar is written in a non cross compilable way for windows I'm not sure how previous build script build windows successfully without install things like VS2019 |
K/KaHyPar/build_tarballs.jl
Outdated
| ] | ||
|
|
||
| # Build the tarballs, and possibly a `build.jl` as well. | ||
| build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; preferred_gcc_version = v"6.1.0") | ||
| build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; julia_compat="1.6", preferred_gcc_version = v"10.2.0") |
There was a problem hiding this comment.
I don't recommend at all using GCC 10. In general use the oldest version of GCC possible, for maximum compatibility. If GCC 6 is enough to build the library, we should stick to it
There was a problem hiding this comment.
OK, I think kahypar recommends GCC 9, should we use GCC 9 then?
There was a problem hiding this comment.
Recommends or requires? Everybody recommends the latest compiler, but we want the largest compatibility possible, which is given by the oldest GCC possible
There was a problem hiding this comment.
it says "requirements" is GCC 9 or higher so I guess it is required: https://github.com/kahypar/kahypar#requirements
There was a problem hiding this comment.
but it seems GCC supports C++17 since GCC 5: https://gcc.gnu.org/projects/cxx-status.html#cxx17
There was a problem hiding this comment.
also should we remove the julia compat, I ran the wizard on julia 1.6, but I guess this is not required.
There was a problem hiding this comment.
OK GCC 7 seems to be the lowest GCC version that works
|
Ok, #3115 is not going to happen anytime soon, so let's go on with this one |
This pull request contains a new build recipe I built using the BinaryBuilder.jl wizard:
@staticfloat please review and merge.