-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcxxwrap_julia for Julia 1.5: rebuild with GCC 8 #2236
Conversation
This may fix the crash reported here: <JuliaInterop/libcxxwrap-julia#75>
I tested this on a Linux machine, and can confirm: with the current 0.8.5 build of |
Thanks for testing. Do we need to build all dependent packages with gcc 8 as well when this is merged? |
Since libcxxwrap-julia is mostly header-based, building the dependents with gcc8 is probably recommended. |
Of course right now we don't know whether this is a fix (i.e.: there is a compiler bug in GCC 7 which caused the original issue)l or a workaround (GCC 8+ optimize differently and hence hide the underlying bug). IMHO the tests @benlorenz performed give some plausibility to the former scenario; alas, that's no proof. In the meantime, I suggest we merge this, and add |
@giordano please merge? |
Did you test only on macOS or also on Linux? Edit: also on Linux |
On both -- specifically, the crash only occurred on Linux so far, so I made that my priority. |
I was worried about the possible symbols with a too high GLIBCXX version (official Julia binaries are built with GCC 7 and that's the libstdc++ currently shipped with Julia), but
shows 3.4.21 at most, which corresponds to GCC v5.1. Looks all good |
This may fix the crash reported here: JuliaInterop/libcxxwrap-julia#75.
Once the binaries are built, I'll verify this locally with an artifact override.
CC @barche @benlorenz