Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable non-POSIX TLS usage in libgomp #1720

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Disable non-POSIX TLS usage in libgomp #1720

merged 1 commit into from
Oct 20, 2020

Conversation

jpsamaroo
Copy link
Contributor

Similar idea to #1716. Should allow libgomp.so to load on musl without any errors.

@jpsamaroo
Copy link
Contributor Author

@giordano a local build of GCC 4 doesn't show a libgomp.so* anywhere; how do I get the shared lib built so that I can test loading it?

@jpsamaroo
Copy link
Contributor Author

Nevermind I found it in the products folder; it loaded with dlopen!

@staticfloat
Copy link
Member

Awesome! So you're saying that actually built GCC with these patches? Which versions did you build?

@giordano
Copy link
Member

giordano commented Oct 1, 2020

For reference see #1418

@jpsamaroo
Copy link
Contributor Author

I built 4.8.5, but I'm now going to fire off builds from 5 up through 9 (the versions I patched for). The patch itself changes very little and only in libgomp, so I don't expect it to break anything.

@giordano giordano added the BinaryBuilder ⚙️ Issues and pull requested related to internals of BinaryBuilder label Oct 2, 2020
@jpsamaroo
Copy link
Contributor Author

Crap, looks like my patches don't work on GCC 5 thru 9....

@jpsamaroo
Copy link
Contributor Author

Nevermind, I was just on the wrong branch. GCC 4-6 have built fine and been successfully dlopen'd. Working on the rest now.

@jpsamaroo
Copy link
Contributor Author

Ok all of them load successfully!

@jpsamaroo
Copy link
Contributor Author

Bump, any objections to merging this?

@staticfloat staticfloat merged commit 564e1d7 into JuliaPackaging:master Oct 20, 2020
@staticfloat
Copy link
Member

Done! Okay, I assume this means we need to rebuild some GCC shards? Only for musl, right?

@jpsamaroo jpsamaroo deleted the jps/libgomp-disable-tls branch October 21, 2020 00:33
@jpsamaroo
Copy link
Contributor Author

Yes please! Just musl, and specifically also CompilerSupportLibraries_jll (which Distributions.jl and various other packages depend on).

@giordano giordano mentioned this pull request Nov 3, 2020
Closed
@giordano giordano mentioned this pull request Jan 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BinaryBuilder ⚙️ Issues and pull requested related to internals of BinaryBuilder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpsamaroo @staticfloat @giordano