use julia_version Pkg.add kwarg rather than specifying it through ctx
#416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/no_ctx
branch
from
e761246 to
5e8fb67
Compare
IanButterworth
force-pushed
the
ib/no_ctx
branch
5 times, most recently
from
76ecd63 to
d5251de
Compare
IanButterworth
force-pushed
the
ib/no_ctx
branch
from
d5251de to
3375fca
Compare
IanButterworth
commented
Feb 24, 2025
Comment on lines
-600
to
+601
| repo=Pkg.Types.GitRepo(rev=git_commit_sha, source=valid_url), | ||
| rev=git_commit_sha, | ||
| url=valid_url, |
There was a problem hiding this comment.
Specifying repo directly isn't compatible with the public Pkg.add API as Pkg.handle_package_input! doesn't expect it to exist, instead constructs it from rev and url etc.
There was a problem hiding this comment.
Improved handling JuliaLang/Pkg.jl#4170
|
@giordano this is good from my perspective now |
|
Haven't looked at the code yet, but this is promising, thanks! I guess a big test is to use this PR in JuliaPackaging/Yggdrasil#10524 (I probably won't have much time this week though). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JuliaLang/Pkg.jl#4161 JuliaLang/Pkg.jl#4160