Fix 7zip path for julia 1.3 #407
Conversation
| if isdefined(Base, :LIBEXECDIR) | ||
| const exe7z = joinpath(Sys.BINDIR, Base.LIBEXECDIR, "7z.exe") | ||
| else | ||
| const exe7z = joinpath(Sys.BINDIR, "7z.exe") |
There was a problem hiding this comment.
| const exe7z = joinpath(Sys.BINDIR, "7z.exe") | |
| const exe7z = joinpath(Compat.Sys.BINDIR, "7z.exe") |
|
Any chance this can be merged? It seems to be breaking ScikitLearn.jl for me |
|
bump yes this is also causing failures |
|
Can we merge this ASAP and tag a release? It's causing any package using BinDeps failure on 1.3 |
|
@ViralBShah I'm not sure who has permissions here, but this is a pretty important PR to get merge and make a release. I'ts has broken Blosc which has broken CMake and by extension HDF5.jl |
|
@musm gave you commit access here. |
|
Thank you very much! |
|
Any chance we can install https://github.com/JuliaRegistries/Registrator.jl here? It can only be performed by organization owners. We'll also need to get in #408 |
|
@musm I have temporarily invited you to be owner of JuliaPackaging, to help smoothen out things here. |
Since it got moved