Slicing support #67
Merged
Slicing support #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! I'd like to see others' thoughts and perhaps discuss a bit, but I'm certainly preliminarily in favor of merging this (or something like it) in! |
mfherbst
reviewed
Feb 8, 2023
|
Looks good, definitely in favour of some version of this. |
- Now only getindex for Integer need to be defined for concrete types and all other slicing automatically work. - Remove the specific implentations from concrete types, - Add tests for getindex with 2D arrays.
mfherbst
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with the key-based property interface we can do
system[:, :property]to get the corresponding:propertyfor all atoms. Wouldn't it also make sense to supportsystem[rng, :property]for a subset,rngof atom indices. Also, from the discussion in #29, I think returning a list of particle objects for slicing is more intuitive and useful. In this PR, I have implemented both of these, i.e., returning vector of particles objects on slicing AbstractSystems and the corresponding extension to the key-based property interface.For example, with this, we can do
system[atomic_symbol(system) .== :H]to get all H atoms.I am just putting this here as a working version to show the usefulness of this feature. Feel free to close this in case we think slicing need not be supported.