-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointer ABI for Windows #16
Conversation
I think arithmetic, comparisons, and basic conversions are working. Tests are currently crashing when doing BigFloat conversions. Could you look that section over again, @simonbyrne ? |
My mistake: I had the limb size of MPFR wrong. Should be working now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo, thanks!
Did you want to make any further changes? Otherwise I'm happy to merge
I tried adding Win32 back to the test matrix (since I found the correct library name), but there is still some problem there - hence the AppVeyor failure above. |
Since Win32 args are on the stack, it should not use Ptr ABI for everything. It requires a sort of hybrid between the *nix and Win64 conventions, but the details are not clear, so implementation and testing agains Win32 are postponed.
cedf4fa
to
d3e9b69
Compare
@simonbyrne I think this is finally ready now that it actually tests the wrappers; I'd suggest a squash+merge. |
src/Quadmath.jl
Outdated
function Float64(x::Float128) | ||
ccall((:__trunctfdf2,quadoplib), Cdouble, (Ref{Cfloat128},), x) | ||
end | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't this need the separate branch to handle the 32-bit windows case?
Thanks @RalphAS for your help! |
The Windows (msys) libraries apparently use pointer ABI for Float128. This is an attempt to accommodate them.