Miles lucas refactor delta

[jverzani]

Version 0.7

• make minor adjustments to @mileslucas big PR

✓ hold off on deprecations; moved into PolyCompat module
✓ adjust roots; doc note to alternatives
✓ drop sorting of roots output. Following issue #185, use a keyword to pass to eigvals
✓ fix variable definition (return monomial x in the polynomial basis)
✓ iteration; add basis method
✓ add round (to go with truncate, chop)
✓ adjust chop! for degree -1 polynomials
✓ remove order as synonym for length; use order term only for derivative
✓ For fit, make deg positional, not a keyword (like Matlab, as I don't like deg for degree.)
✓ change to iszero from == zero(T) in showterm
✓ Close issue #189 for p(A::Array) for Polynomial and Poly type. Not for ChebyshevT (as x ∉ domain(p) isn't satisfied
✓ adjust type calculation for derivative; adjust derivative(::ChebyshevT...) to use recursion for order > 1
✓ Close issue #194

--> Plots
✓ plot recipe respects domain if finite
✓ tighten range of plot recipe
✓ adjust tests for change of tightening

--> Chebyshev
✓ ChebyshevT: fix derivative if order > degree
✓ ChebyshevT: make copy, as derivative modifies p
✓ ChebyshevT: make basis more explicit when printing

--> Docs
✓ docs to emphasize basis
✓ change doc order -> degree

--> run some benchmarks
✓ add Base.:+(p::Polynomial{T}, c::S) where {T,S<:Number} method
✓ add @inbounds for p*q; use one(x) in places
✓ fit: use vand \ y in place of pinv(vand) * y
✓ divrem: avoid R.(num[0:n]), as it is slower than typed comprehension

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@4c99692). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #196   +/-   ##
=========================================
  Coverage          ?   89.51%           
=========================================
  Files             ?       10           
  Lines             ?      677           
  Branches          ?        0           
=========================================
  Hits              ?      606           
  Misses            ?       71           
  Partials          ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c99692...2831c82. Read the comment docs.

[mileslucas]

I’ll be honest it’s nice to see this get merged! It had been so long since I wrote it 😅 thanks for all the help tightening the PR up and getting this ready to push out!!

[jverzani]

Sorry it took so long. It is a really great improvement!

…

On Tue, Apr 7, 2020 at 5:37 PM Miles Lucas ***@***.***> wrote: I’ll be honest it’s nice to see this get merged! It had been so long since I wrote it 😅 thanks for all the help tightening the PR up and getting this ready to push out!! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#196 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADG6TFGIXJGWB6D4I52METRLOMK7ANCNFSM4MDLTPQQ> .

-- John Verzani Department of Mathematics College of Staten Island, CUNY verzani@math.csi.cuny.edu