Add comment about x.i comparisons in negative / abs checks

JuliaMath · Dec 19, 2023 · 00079e8 · 00079e8
1 parent e9089f0
commit 00079e8
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/FixedPointDecimals.jl b/src/FixedPointDecimals.jl
@@ -440,10 +440,12 @@ end
 
 function Base.checked_neg(x::T) where {T<:FD}
     r = -x
-    (x.i<0) & (r<0) && Base.Checked.throw_overflowerr_negation(x)
+    # Simplify the compiler's job, no need to call the FD,Int comparison
+    (x.i<0) & (r.i<0) && Base.Checked.throw_overflowerr_negation(x)
     return r
 end
 function Base.checked_abs(x::FD)
+    # Simplify the compiler's job, no need to call the FD,Int comparison
     r = ifelse(x.i<0, -x, x)
     r.i<0 || return r
     _throw_overflow_abs(x)