Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inference, bump AbstractFFTs [compat] #173

Merged
merged 1 commit into from
Jan 1, 2021
Merged

Improve inference, bump AbstractFFTs [compat] #173

merged 1 commit into from
Jan 1, 2021

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 24, 2020

@timholy
Copy link
Member Author

timholy commented Dec 24, 2020

Looks like the mirrors just haven't updated yet.

@timholy timholy closed this Dec 26, 2020
@timholy timholy reopened this Dec 26, 2020
@timholy
Copy link
Member Author

timholy commented Dec 26, 2020

Closing/opening reran travis but not the others.

@giordano
Copy link
Member

Related to last comment, #172 is ready for review

@timholy
Copy link
Member Author

timholy commented Dec 26, 2020

If we want to merge #172 and then rebase this, that would be fine with me.

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #173 (b406344) into master (feebdb5) will decrease coverage by 0.58%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   67.75%   67.16%   -0.59%     
==========================================
  Files           3        3              
  Lines         400      402       +2     
==========================================
- Hits          271      270       -1     
- Misses        129      132       +3     
Impacted Files Coverage Δ
src/fft.jl 63.66% <80.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feebdb5...b406344. Read the comment docs.

@timholy
Copy link
Member Author

timholy commented Dec 29, 2020

Are those windows failures expected?

@giordano
Copy link
Member

giordano commented Dec 29, 2020

Are those windows failures expected?

Yes, same as #172 (comment). I might know what's the problem, but didn't have the time to better investigate it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants