Fix addition #63
Merged
Fix addition #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 99.21% 99.22%
=======================================
Files 6 6
Lines 128 129 +1
=======================================
+ Hits 127 128 +1
Misses 1 1 ☔ View full report in Codecov by Sentry. |
The addition did not work for two numbers with exponents `q1` and `q2` such that `d = abs(q1 - q2) > 18` because it led to a power `10^d` which overflows for `d>18`. This commit makes that `10` a `BigInt` to prevent overflow. Besides that, the code is simplified a little. Fixes JuliaMath#62
|
Hello @barucden, as mentioned in the other thread, until we can get you set up as a maintainer, I'm happy to merge in PRs that you think are ready, as it seems that this library is substantially broken currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition did not work for two numbers with exponents
q1andq2such thatd = abs(q1 - q2) > 18because it led to a power10^dwhich overflows ford>18. This commit makes that10aBigIntto prevent overflow.Besides that, the code is simplified a little.
Fixes #62