Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package doesn't work in Julia 0.5 #18

Closed
giordano opened this issue Jun 7, 2016 · 6 comments · Fixed by #19
Closed

Package doesn't work in Julia 0.5 #18

giordano opened this issue Jun 7, 2016 · 6 comments · Fixed by #19

Comments

@giordano
Copy link
Member

giordano commented Jun 7, 2016

At least since 2016-05-24 (see http://pkg.julialang.org/detail/Cubature.html) this package doesn't work in Julia 0.5. This is an excerpt from http://pkg.julialang.org/logs/Cubature_0.5.log:

ERROR: LoadError: sigatomic_end called in non-sigatomic region
 in cubature(::Bool, ::Bool, ::Bool, ::Bool, ::Int64, ::Function, ::Int64, ::Int64, ::Float64, ::Float64, ::Int64, ::Int32) at /home/vagrant/.julia/v0.5/Cubature/src/Cubature.jl:213
 in #hquadrature#12(::Float64, ::Float64, ::Int64, ::Function, ::Function, ::Int64, ::Int64) at /home/vagrant/.julia/v0.5/Cubature/src/Cubature.jl:227
 in (::Cubature.#kw##hquadrature)(::Array{Any,1}, ::Cubature.#hquadrature, ::Function, ::Int64, ::Int64) at ./null:0
 in include_from_node1(::String) at ./loading.jl:426
 in process_options(::Base.JLOptions) at ./client.jl:266
 in _start() at ./client.jl:322
while loading /home/vagrant/.julia/v0.5/Cubature/test/runtests.jl, in expression starting on line 7
@stevengj
Copy link
Member

stevengj commented Jul 5, 2016

@yuyichao, is this due to the changes in JuliaLang/julia#16174?

Cubature is calling sigatomic_begin explicitly before the ccall, then sigatomic_end/sigatomic_begin inside a Julia callback to temporarily re-enable exceptions, then finally sigatomic_end after the ccall. I thought this was still the correct thing to do according to your comment?

@yuyichao
Copy link
Contributor

yuyichao commented Jul 5, 2016

It should be fine. The sigatomic counter is task local now, does this package use tasks?

@stevengj
Copy link
Member

stevengj commented Jul 5, 2016

No, it doesn't use tasks.

@yuyichao
Copy link
Contributor

yuyichao commented Jul 5, 2016

Briefly looking at code, the issue might be that the counter is resetting in catch

@stevengj
Copy link
Member

stevengj commented Jul 5, 2016

Why would the counter reset, as opposed to just decrement?

@stevengj
Copy link
Member

stevengj commented Jul 5, 2016

I isolated this into a pure Julia example that illustrates the same error, and filed it as JuliaLang/julia#17281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants