-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pratio and maxdim #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eliascarv I can give a more detailed review after 17hs BRT today. I wonder if we should preserve the semantic of ndim and use ndim and pratio as mutually exclusive options. That is what I had in mind originally.
Let's chat over Zulip to align detail later today.
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 93.12% 93.62% +0.50%
==========================================
Files 23 24 +1
Lines 567 596 +29
==========================================
+ Hits 528 558 +30
+ Misses 39 38 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review attached.
Amazing PR as usual @eliascarv , super clean and professional coding 💯 Let's just wait for the tests to pass. |
This PR adds
pratio
option toEigenAnalysis
and changendim
tomaxdim
.I made some decisions to this implementation:
pratio
andmaxdim
kwargs to give the user option to choose one of these, both or neither.ndim
tomaxdim
to make sense withpratio
implementation.closes #88