Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RowTable and ColTable #65

Merged
merged 9 commits into from
May 2, 2022
Merged

Add RowTable and ColTable #65

merged 9 commits into from
May 2, 2022

Conversation

ceferisbarov
Copy link
Contributor

@ceferisbarov ceferisbarov commented Apr 30, 2022

Fix #62

Added RowTable transform and its tests.

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2022

Codecov Report

Merging #65 (048cf63) into master (6363d8f) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   92.36%   92.46%   +0.09%     
==========================================
  Files          19       21       +2     
  Lines         498      504       +6     
==========================================
+ Hits          460      466       +6     
  Misses         38       38              
Impacted Files Coverage Δ
src/transforms.jl 97.82% <ø> (ø)
src/transforms/coltable.jl 100.00% <100.00%> (ø)
src/transforms/rowtable.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6363d8f...048cf63. Read the comment docs.

Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a first round of reviews. Feel free to add ColTable to this PR as well given that it is pretty much the same code.

src/transforms/rowtable.jl Outdated Show resolved Hide resolved
src/transforms/rowtable.jl Outdated Show resolved Hide resolved
test/transforms.jl Show resolved Hide resolved
src/transforms/coltable.jl Outdated Show resolved Hide resolved
src/transforms/rowtable.jl Outdated Show resolved Hide resolved
@juliohm juliohm changed the title Add Rowtable Add RowTable and ColTable May 2, 2022
ceferisbarov and others added 2 commits May 2, 2022 11:53
Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com>
Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com>
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, now we need to add the two transforms to the documentation like the other transforms.

@eliascarv eliascarv requested a review from juliohm May 2, 2022 12:35
test/transforms.jl Outdated Show resolved Hide resolved
test/transforms.jl Outdated Show resolved Hide resolved
@juliohm juliohm merged commit 735e507 into JuliaML:master May 2, 2022
@juliohm
Copy link
Member

juliohm commented May 2, 2022

Awesome! Thank you! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce RowTable and ColTable transforms
4 participants