-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ColSpec #30
ColSpec #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing PR as usual. Just a few adjustments before we can merge it.
This PR is ready for a final review @juliohm! |
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 92.48% 92.73% +0.25%
==========================================
Files 15 16 +1
Lines 399 413 +14
==========================================
+ Hits 369 383 +14
Misses 30 30
Continue to review full report at Codecov.
|
This PR makes the ColSpec interface more generic so it can be used in all transformations that use column selections.