Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the UCI Wine dataset #207

Merged
merged 2 commits into from
Feb 11, 2023
Merged

Adding the UCI Wine dataset #207

merged 2 commits into from
Feb 11, 2023

Conversation

Tambup
Copy link
Contributor

@Tambup Tambup commented Feb 11, 2023

This commit contains the code to build the dataset, a .csv file from https://gist.github.com/tijptjik/9408623, the documentation and test. Everything is based on the current work present in the master branch.

I think this can be useful as it contains more than just two classes but remains quite easy to solve. So, useful to test non-binary classifiers.

I built the documentation locally and it works as expected.
Manual tests has been conducted with success.
Unit Tests has not been concluded (my machine runs out of memory...).

This commit contains the code to build the dataset, a .csv file from https://gist.github.com/tijptjik/9408623, the documentation and test.
Everything is based on the current work present in the master branch.
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Merging #207 (2c48ed6) into master (86dabc4) will increase coverage by 0.38%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   48.56%   48.94%   +0.38%     
==========================================
  Files          44       45       +1     
  Lines        2261     2278      +17     
==========================================
+ Hits         1098     1115      +17     
  Misses       1163     1163              
Impacted Files Coverage Δ
src/MLDatasets.jl 100.00% <ø> (ø)
src/datasets/misc/wine.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CarloLucibello CarloLucibello merged commit 42e6f5e into JuliaML:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants