Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple labels for nodes, edges and graphs #196

Merged
merged 3 commits into from
Dec 23, 2022

Conversation

Dsantra92
Copy link
Collaborator

@Dsantra92 Dsantra92 commented Dec 20, 2022

Our TUDataset implementation didn't support a node, edge or graph having multiple labels. A simple change in delimiter allows us to read all the labels correctly. Ideally closes #195

ToDo:

  • Tests for Cuneiform

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #196 (0f014de) into master (b9a6f71) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   41.64%   41.64%           
=======================================
  Files          43       43           
  Lines        2226     2226           
=======================================
  Hits          927      927           
  Misses       1299     1299           
Impacted Files Coverage Δ
src/datasets/graphs/tudataset.jl 1.36% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Dsantra92 Dsantra92 marked this pull request as draft December 20, 2022 01:25
@Dsantra92 Dsantra92 marked this pull request as ready for review December 20, 2022 02:04
@CarloLucibello
Copy link
Member

It's weird to have a label matrix, they should be separate feature vectors, but since we don't have separate names for them I guess it is ok to let the users handle them.
A simple test for issue #195 and we can merge.

@CarloLucibello CarloLucibello merged commit dac5a8e into master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some TU Datasets do not work - Error when loading
3 participants