Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all the LinearAlgebra tests #86

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Run all the LinearAlgebra tests #86

merged 1 commit into from
Sep 18, 2021

Conversation

ViralBShah
Copy link
Contributor

@ViralBShah ViralBShah commented Sep 17, 2021

Fix for #70

Note that for Julia versions older than 1.7, the system image (with MKL) building fails because the process of overwriting it is unreliable in CI (e.g. on macOS we can't overwrite at all, and linux and windows have other issues). This will not really be a problem since 1.7 will be out soon and so the stable as well as the nightly tests will pass.

We don't expect this package to change a whole lot. The main purpose of these tests is actually for PkgEval.

@ViralBShah ViralBShah marked this pull request as draft September 18, 2021 00:07
@ViralBShah ViralBShah marked this pull request as ready for review September 18, 2021 01:33
@ViralBShah ViralBShah merged commit 0578211 into master Sep 18, 2021
@ViralBShah ViralBShah deleted the vs/test branch September 18, 2021 01:42
@KristofferC
Copy link
Contributor

Did you confirm that the linear algebra test here are run with MKL? The tests are run in a new process and I dont see what would load MKL in that process.

@ViralBShah
Copy link
Contributor Author

Ok. I need to load the MKL package then in the new process. How do I do that? Maybe I should not use Pkg.test().

@KristofferC
Copy link
Contributor

Yes, maybe just

include(joinpath(Sys.STDLIB, "LinearAlgebra", "test", "runtests.jl"))

@ViralBShah
Copy link
Contributor Author

Trying that in #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants