Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml for codecov v4 #229

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Update ci.yml for codecov v4 #229

merged 2 commits into from
Jun 24, 2024

Conversation

JeffFessler
Copy link
Member

Hopefully addresses #228

@JeffFessler
Copy link
Member Author

I have no idea why julia 1.6 for macOS failed.

@dkarrasch dkarrasch closed this Jun 11, 2024
@dkarrasch dkarrasch reopened this Jun 11, 2024
@dkarrasch
Copy link
Member

Could you please rebase onto current master? I relaxed the CI configuration a bit. I suspect that this works just fine, but would like to see some confirmation.

@JeffFessler
Copy link
Member Author

Sadly I don't know how to do that, and I bet it will be faster for you to just close this PR and make a new PR than to teach me how! And that's OK. Is there is a github button I am overlooking for it? I tried to RTFM:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#rebase-and-merge-your-commits

@dkarrasch
Copy link
Member

Indeed, I'm also missing that "rebase" button that I'm used to from the julia repo. @fredrikekre Do you know where to set this up?

I'll still share what I learnt from others in the community. After you updated your local master branch, you switch to the PR branch and then do

git pull --rebase origin master

to pull from master and rebase the current branch. Afterwards, you can resolve merge conflicts if necessary and then

git push --force

@dkarrasch
Copy link
Member

I think I found the button.

@dkarrasch
Copy link
Member

Seems like it still doesn't solve the problem? I'm seeing

Upload failed: {"detail":"You do not have permission to perform this action."}

in the CI / Julia1 - ubuntu-latest run.

@fredrikekre
Copy link
Member

That is because this PR is from a fork and the secret is not available.

@dkarrasch dkarrasch merged commit 37cf32d into master Jun 24, 2024
10 of 12 checks passed
@dkarrasch dkarrasch deleted the JeffFessler/codecov branch June 24, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants