Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work-around Franklin bugs #2157

Merged
merged 4 commits into from
Oct 5, 2024
Merged

Work-around Franklin bugs #2157

merged 4 commits into from
Oct 5, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Oct 5, 2024

Fixes #2144

Copy link

github-actions bot commented Oct 5, 2024

Once the build has completed, you can preview your PR at this URL: https://julialang.netlify.app/previews/PR2157/ in ~15 minutes

@IanButterworth IanButterworth force-pushed the ib/pagevar_fix branch 2 times, most recently from 876bcdf to 663e54a Compare October 5, 2024 18:12
@IanButterworth
Copy link
Member Author

I'm fixing a few issues here, but it seems that the reason that the descriptions aren't being found is a bug in Franklin where it's supposed to, but no longer checking for a rss field, instead only rss_description
https://github.com/tlienart/Franklin.jl/blob/c06db25f51fa25e97db88c5b5d3a5dff657687e9/src/manager/write_page.jl#L221-L224

Also it seems that pagevar is an internal expects top level calls to have reset Franklin.PAGEVAR_DEPTH[] = 0 to guard against recursion. I don't believe that was the error here, but as noted before it was in another case, so I've set it to always be reset before a pagevar call. Seems adding a proper pagevar function to the API would be good?

fyi @tlienart

@IanButterworth IanButterworth marked this pull request as ready for review October 5, 2024 18:14
@IanButterworth
Copy link
Member Author

I guess this was also not generating RSS feeds.. but I have no idea if that's a thing or how it works.

@IanButterworth IanButterworth changed the title reset Franklin.PAGEVAR_DEPTH before each internal pagevar call Work-around Franklin bugs Oct 5, 2024
@IanButterworth
Copy link
Member Author

I propose we merge this to fix the website, then investigate upstream Franklin fixes, then consider reverting unneeded parts of this once fixes are in.

@IanButterworth IanButterworth merged commit 29298bc into main Oct 5, 2024
2 checks passed
@IanButterworth IanButterworth deleted the ib/pagevar_fix branch October 5, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent blog posts shows "nothing" for the blog post content
1 participant