Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print user-defined type names fully qualified. #9100

Merged
merged 1 commit into from
Nov 24, 2014
Merged

Conversation

StefanKarpinski
Copy link
Member

This seems significantly more helpful and informative to me much of the time.

@StefanKarpinski StefanKarpinski changed the title print type names fully qualified, e.g. Core.Int64. print user-defined type names fully qualified. Nov 21, 2014
@toivoh
Copy link
Contributor

toivoh commented Nov 22, 2014

+1

@vtjnash
Copy link
Member

vtjnash commented Nov 24, 2014

+1. any reason you didn't already just merge this?

@StefanKarpinski
Copy link
Member Author

Wanted some feedback, but I guess I can just see if anyone hollers after I do it.

StefanKarpinski added a commit that referenced this pull request Nov 24, 2014
print user-defined type names fully qualified.
@StefanKarpinski StefanKarpinski merged commit c1005a2 into master Nov 24, 2014
@quinnj
Copy link
Member

quinnj commented Dec 2, 2014

FWIW, I've been using this for a few days now and love it. +1

@StefanKarpinski
Copy link
Member Author

It does seems like a big improvement to me as well.

@timholy
Copy link
Member

timholy commented Dec 3, 2014

It caused a small hiccup in Images, but it was easily fixed. There are certainly some advantages to this.

@ivarne ivarne deleted the sk/typenames branch December 3, 2014 08:43
ivarne added a commit that referenced this pull request Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants