-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added windows support for SharedArray #9044
Conversation
Awesome. LGTM. Will merge in a day if there are no concerns raised. cc: @vtjnash |
if create | ||
flprotect = ro ? 0x02 : 0x04 | ||
mmaphandle = ccall(:CreateFileMappingW, stdcall, Ptr{Void}, (Cptrdiff_t, Ptr{Void}, Cint, Cint, Cint, Ptr{UInt16}), | ||
hdl, C_NULL, flprotect, szfile>>32, szfile&typemax(UInt32), name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing utf16
call? or perhaps this is handled automatically now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 141
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah. good call
@amitmurthy Just bumping this - You mentioned someone who needed this capability on windows. |
Added windows support for SharedArray
This should backport cleanly, however, we should let it bake in this branch for a while before doing so. Adding a @JuliaBackports just for reference. |
Yay, this is great! Thanks, @twadleigh! |
@timholy, I'm very gratified to have been able to contribute something useful to base. |
would prefer testing it for a while on master before backporting, 0.3.3 is scheduled for pretty soon |
That's what I meant. What is the protocol for adding a |
both the notification and the label are useful, but for commits that aren't attached to a PR we can only use the notification. |
The backport window is open now for 0.3.4-pre. This doesn't cherry-pick cleanly and should be done carefully due to things like |
Backport of JuliaLang#9044 merged to master in 9c9597d.
Backport of JuliaLang#9044 merged to master in 9c9597d.
thanks @twadleigh for preparing the backport. removing the label from here since it's now covered by #9148 |
I made every effort to implement this with the least amount of change to existing code. This includes trying to maximize reuse of the existing windows version of the
mmap_array
function. One not-so-pleasing side effect of this is a clunkier looking signature with aUnion
type and a couple of newif-else
blocks in the body.I verified that
test/parallel.jl
passes on linux-64, windows-32, and windows-64 on my machine.