Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8200 (and reopen #8156) #8218

Closed
wants to merge 1 commit into from
Closed

Fix #8200 (and reopen #8156) #8218

wants to merge 1 commit into from

Conversation

kmsquire
Copy link
Member

@kmsquire kmsquire commented Sep 3, 2014

As suggested my @nolta. This seems to fix the build problems in #8200 for me.

Cc: @JeffBezanson

Revert "allow more kinds of fields to take 0 space. fixes #8156"

This reverts commits 662cd0a,
                     6667e5d.
@JeffBezanson
Copy link
Member

Why? This is an unstable development version. We should fix it, not just revert things.

@StefanKarpinski
Copy link
Member

I think it was causing a lot of trouble. We've also tended not to keep master in a state where it segfaults half of the time.

@kmsquire
Copy link
Member Author

kmsquire commented Sep 3, 2014

Those two points of view were why I didn't merge right away. :-)

It's been rather difficult to see anything pass on Travis recently, so this
was meant as a stopgap. The best thing is just to fix it, of course, but
that would take me a lot longer than you, Jeff.

Cheers!

On Wednesday, September 3, 2014, Stefan Karpinski notifications@github.com
wrote:

I think it was causing a lot of trouble. We've also tended not to keep
master in a state where it segfaults half of the time.


Reply to this email directly or view it on GitHub
#8218 (comment).

@ivarne
Copy link
Member

ivarne commented Sep 3, 2014

The more stable master is, the more users follow on master and the more people have a incentive to contribute patches and give early feedback on features. The earlier we get bug reports (and fix them) the better impression people will have on Julia, and the more developers we will get to help us reach a 1.0 release.

#8200 is much more annoying than #8156, so until we get a proper fix for the segfault, I think that reverting temporary is a good solution.

@ivarne
Copy link
Member

ivarne commented Sep 3, 2014

See #8110 (comment), for a concrete example where having this bug scares people away from participating.

@JeffBezanson
Copy link
Member

Naturally I would not have pushed these if I saw the segfault locally. Fortunately I can reproduce it on my laptop.

@staticfloat
Copy link
Member

Great, I'll release the buildbot back to its business then. :P

@kmsquire kmsquire deleted the kms/fix_build branch February 25, 2015 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants