accept more Integer types for dims::Int... arguments #7956
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the mailing list, there's no real reason that functions like
rand(dims::Int...)
can't accept otherInteger
types. This patch genericizes a number of functions inBase
that tookInt...
arguments to acceptInteger...
.There shouldn't be a performance penalty, since I made sure
convert(Dims, dims::Dims)
returnsdims
by adding a new diagonal tuple method toconvert
.Functions accepting an explicit
(Int...)
(== Dims
) tuple still requireInt
; it was too much of a pain to change these, and they are generally lower-level functions than the varargs functions.