Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7197, backport a fix to SimplifyDemandedUseBits in LLVM #7313

Merged
merged 2 commits into from
Jun 19, 2014

Conversation

JeffBezanson
Copy link
Member

No description provided.

@Keno
Copy link
Member

Keno commented Jun 19, 2014

LGTM

@JeffBezanson
Copy link
Member Author

Ok, this seems to cause the simdloop test to crash on travis. Works for me locally.

@Keno
Copy link
Member

Keno commented Jun 19, 2014

Did you test with system llvm?

@JeffBezanson
Copy link
Member Author

No, just mine without this patch. Could it be an interaction with one of the other patches?

@Keno
Copy link
Member

Keno commented Jun 19, 2014

What I'm saying is that travis has USE_SYSTEM_LLVM=1 and maybe the simd test relies on having the instcombine pass.

@JeffBezanson
Copy link
Member Author

I tried manually defining INSTCOMBINE_BUG. So it would have to be the case that the simd test relies on the instcombine pass, unless our other patches are applied? Seems strange.

@Keno
Copy link
Member

Keno commented Jun 19, 2014

Sure does. Alternatively it might be processor architecture dependent. Especially with simd that could make sense. You could try playing around with the jl_cpu_string setting.

JeffBezanson added a commit that referenced this pull request Jun 19, 2014
fix #7197, backport a fix to SimplifyDemandedUseBits in LLVM
@JeffBezanson JeffBezanson merged commit 460e5e5 into master Jun 19, 2014
@JeffBezanson JeffBezanson deleted the jb/instcombine_patch branch August 10, 2014 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants